add SoftwareEngineer, FrontendDeveloper, BackendDeveloper, AndroidDeve… #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loper, FullStackDeveloper i think need to use Mixins and i add FrontDevMixin, BackDevMixin, AndroidDevMixin
vsmutok
suggested changes
Sep 15, 2024
app/main.py
Outdated
Comment on lines
43
to
46
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ["Python", "SQL", "Django", | ||
| "JavaScript", "HTML", "CSS", ] |
app/main.py
Outdated
| class FrontendDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ["JavaScript", "HTML", "CSS", ] |
There was a problem hiding this comment.
Suggested change
| self.skills = ["JavaScript", "HTML", "CSS", ] | |
| self.skills += ["JavaScript", "HTML", "CSS", ] |
You should not override skills, but update them.
app/main.py
Outdated
Comment on lines
49
to
52
| print(f"{self.name} started creating a web application...") | ||
| print(f"{self.name} is creating an API...") | ||
| print(f"{self.name} is creating a webpage...") | ||
| return |
There was a problem hiding this comment.
use create_powerful_api and create_awesome_web_page methods here
plus skills in class use self.create_powerful_api and self.create_awesome_web_page
vsmutok
suggested changes
Sep 15, 2024
app/main.py
Outdated
Comment on lines
40
to
42
| class FullStackDeveloper(FrontendDeveloper, | ||
| BackendDeveloper): | ||
|
|
There was a problem hiding this comment.
Suggested change
| class FullStackDeveloper(FrontendDeveloper, | |
| BackendDeveloper): | |
| class FullStackDeveloper(FrontendDeveloper, BackendDeveloper): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loper, FullStackDeveloper
i think need to use Mixins and i add FrontDevMixin, BackDevMixin, AndroidDevMixin